-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NXNAME RR type and invalid query type EDE #392
Conversation
Did something go wrong? IANA class it 'NXNAME', the PR seems to have NXDOMAIN? |
43a81a0
to
06cd22c
Compare
You're 100% right, it should be NXNAME to match the IANA reserved |
06cd22c
to
3783c53
Compare
Hi there, is there anything else the team would like out of this PR? |
I notice that https://datatracker.ietf.org/doc/draft-ietf-dnsop-compact-denial-of-existence/ has not yet finished moving through the IETF process nor has the RFC been updated yet to reflect the new IANA EDE code point. Given that the IANA code point has now been allocated (at least it appears at https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#extended-dns-error-codes) I assume it is low risk to merge this PR while the IETF process is ongoing. |
3783c53
to
c70b358
Compare
This is our assumption as well given that they've been allocated, in the small chance that anything changes I'll be back |
c70b358
to
8916a8a
Compare
https://datatracker.ietf.org/doc/draft-ietf-dnsop-compact-denial-of-existence/ is in the final stages for RFC publication and while that may still result in changes to the final document, the allocation of the NXNAME type and the new EDE code is not going to be changed so is safe to import. IANA does not have a habit of changing allocated types meaning that worst case the allocated code point is burned and considered deprecated in the future. |
Adding NXNAME resource record type and the EDE code to reject invalid queries for it
EDE 30 and NXNAME are both IANA reserved